diff options
| author | Markus Uhlin <markus@nifty-networks.net> | 2026-03-14 13:28:49 +0100 |
|---|---|---|
| committer | Markus Uhlin <markus@nifty-networks.net> | 2026-03-14 13:28:49 +0100 |
| commit | 570965251c0a6d21bfcfd6a454b278b530c5650b (patch) | |
| tree | c4f35ee59143c532c24f16929ada11a4463de6b3 | |
| parent | 0f792053d9fecafbc699dee5966f4c7d88e21a44 (diff) | |
player_write_logout: handle snprintf() truncation
| -rw-r--r-- | FICS/playerdb.c | 18 |
1 files changed, 11 insertions, 7 deletions
diff --git a/FICS/playerdb.c b/FICS/playerdb.c index b1c3d73..599c9f1 100644 --- a/FICS/playerdb.c +++ b/FICS/playerdb.c @@ -1726,20 +1726,24 @@ player_write_login(int p) PUBLIC void player_write_logout(int p) { - char fname[MAX_FILENAME_SIZE]; + char fname[MAX_FILENAME_SIZE] = { '\0' }; + int ret; if (parray[p].registered) { - snprintf(fname, sizeof fname, "%s/player_data/%c/%s.%s", + ret = snprintf(fname, sizeof fname, "%s/player_data/%c/%s.%s", stats_dir, parray[p].login[0], parray[p].login, STATS_LOGONS); - write_p_inout(P_LOGOUT, p, fname, 8); + if (!is_too_long(ret, sizeof fname)) + write_p_inout(P_LOGOUT, p, fname, 8); } - snprintf(fname, sizeof fname, "%s/%s", stats_dir, STATS_LOGONS); - write_p_inout(P_LOGOUT, p, fname, 30); + ret = snprintf(fname, sizeof fname, "%s/%s", stats_dir, STATS_LOGONS); + if (!is_too_long(ret, sizeof fname)) + write_p_inout(P_LOGOUT, p, fname, 30); - snprintf(fname, sizeof fname, "%s/%s", stats_dir, "logons.log"); - write_p_inout(P_LOGOUT, p, fname, 0); + ret = snprintf(fname, sizeof fname, "%s/%s", stats_dir, "logons.log"); + if (!is_too_long(ret, sizeof fname)) + write_p_inout(P_LOGOUT, p, fname, 0); } PUBLIC time_t |