diff options
| author | Markus Uhlin <markus@nifty-networks.net> | 2025-02-11 19:58:49 +0100 |
|---|---|---|
| committer | Markus Uhlin <markus@nifty-networks.net> | 2025-02-11 19:58:49 +0100 |
| commit | daaf6b9a8cd549b0ee8be4f34665f1460472f803 (patch) | |
| tree | 25a26e1ceb433f0a06ccccc0115b29edda459ce8 | |
| parent | 27d12a60336276e7fc7a2b3acde321549a30b0b3 (diff) | |
player_find_part_login: calc string length once (found by PVS-Studio)
| -rw-r--r-- | FICS/playerdb.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/FICS/playerdb.c b/FICS/playerdb.c index f9e9410..cbd02c7 100644 --- a/FICS/playerdb.c +++ b/FICS/playerdb.c @@ -1282,10 +1282,13 @@ player_find_part_login(char *name) { int found = -1; int i; + size_t namelen; if ((i = player_find_bylogin(name)) >= 0) return i; + namelen = strlen(name); + for (i = 0; i < p_num; i++) { if (parray[i].status == PLAYER_EMPTY || parray[i].status == PLAYER_LOGIN || @@ -1295,7 +1298,7 @@ player_find_part_login(char *name) if (!parray[i].login) continue; - if (!strncmp(parray[i].login, name, strlen(name))) { + if (!strncmp(parray[i].login, name, namelen)) { if (found >= 0) /* Ambiguous */ return -2; found = i; |