From daaf6b9a8cd549b0ee8be4f34665f1460472f803 Mon Sep 17 00:00:00 2001 From: Markus Uhlin Date: Tue, 11 Feb 2025 19:58:49 +0100 Subject: player_find_part_login: calc string length once (found by PVS-Studio) --- FICS/playerdb.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/FICS/playerdb.c b/FICS/playerdb.c index f9e9410..cbd02c7 100644 --- a/FICS/playerdb.c +++ b/FICS/playerdb.c @@ -1282,10 +1282,13 @@ player_find_part_login(char *name) { int found = -1; int i; + size_t namelen; if ((i = player_find_bylogin(name)) >= 0) return i; + namelen = strlen(name); + for (i = 0; i < p_num; i++) { if (parray[i].status == PLAYER_EMPTY || parray[i].status == PLAYER_LOGIN || @@ -1295,7 +1298,7 @@ player_find_part_login(char *name) if (!parray[i].login) continue; - if (!strncmp(parray[i].login, name, strlen(name))) { + if (!strncmp(parray[i].login, name, namelen)) { if (found >= 0) /* Ambiguous */ return -2; found = i; -- cgit v1.2.3