From e86a270689db5d2aac02991ad40773c059ce6ecc Mon Sep 17 00:00:00 2001
From: Markus Uhlin <markus@nifty-networks.net>
Date: Thu, 6 Mar 2025 05:31:08 +0100
Subject: Calc string length once (found by PVS-Studio)

---
 FICS/adminproc.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

(limited to 'FICS')

diff --git a/FICS/adminproc.c b/FICS/adminproc.c
index 07647f0..addf5be 100644
--- a/FICS/adminproc.c
+++ b/FICS/adminproc.c
@@ -499,9 +499,15 @@ com_anews(int p, param_list param)
 PUBLIC int
 strcmpwild(char *mainstr, char *searchstr)
 {
-	if (strlen(mainstr) < strlen(searchstr))
+	size_t len[2];
+
+	len[0] = strlen(mainstr);
+	len[1] = strlen(searchstr);
+
+	if (len[0] < len[1])
 		return 1;
-	for (size_t i = 0; i < strlen(mainstr); i++) {
+
+	for (size_t i = 0; i < len[0]; i++) {
 		if (searchstr[i] == '*')
 			return 0;
 		if (mainstr[i] != searchstr[i])
-- 
cgit v1.2.3