From 95b9d5d4fabd826a4ec073f8ebf97bd56c3ac247 Mon Sep 17 00:00:00 2001
From: Markus Uhlin <markus@nifty-networks.net>
Date: Wed, 3 Jan 2024 03:33:54 +0100
Subject: Check fgets() return value and use sizeof
---
FICS/makerank.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
(limited to 'FICS')
diff --git a/FICS/makerank.c b/FICS/makerank.c
index b1aa8de..299e72e 100644
--- a/FICS/makerank.c
+++ b/FICS/makerank.c
@@ -36,12 +36,9 @@ GetPlayerInfo(char *fileName, ENTRY *e)
e->r[i].rating = 0;
}
- if ((fp = fopen(fileName, "r")) == NULL)
- return 0;
-
- fgets(line, 99, fp);
-
- if (feof(fp))
+ if ((fp = fopen(fileName, "r")) == NULL ||
+ fgets(line, sizeof line - 1, fp) == NULL ||
+ feof(fp))
return 0;
if (!strcmp(line, "v 1\n")) {
--
cgit v1.2.3