From 75e718a3df2be1dee37ec18266e61ede8d2063c3 Mon Sep 17 00:00:00 2001
From: Markus Uhlin <markus@nifty-networks.net>
Date: Wed, 3 Jan 2024 04:18:33 +0100
Subject: Check for truncation

---
 FICS/makerank.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/FICS/makerank.c b/FICS/makerank.c
index d8be7f6..3e33ac9 100644
--- a/FICS/makerank.c
+++ b/FICS/makerank.c
@@ -187,9 +187,11 @@ SetComputers(int n)
 	char	 line[100];
 	int	 i = 0;
 
-	snprintf(line, sizeof line, "sort -f %s", COMPUTER_FILE);
-
-	if ((fpComp = popen(line, "r")) == NULL)
+	if (snprintf(line, sizeof line, "sort -f %s", COMPUTER_FILE) >=
+	    sizeof line) {
+		warnx("%s: snprintf truncated", __func__);
+		return 0;
+	} else if ((fpComp = popen(line, "r")) == NULL)
 		return 0;
 
 	while (i < n) {
-- 
cgit v1.2.3