From 2de83a811647603f59b3d4808979ec0c52e8d3f2 Mon Sep 17 00:00:00 2001 From: Markus Uhlin Date: Sun, 9 Mar 2025 00:01:15 +0100 Subject: CheckRepetition: calc string length once (found by PVS-Studio) --- FICS/gameproc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/FICS/gameproc.c b/FICS/gameproc.c index b4a538e..1af99de 100644 --- a/FICS/gameproc.c +++ b/FICS/gameproc.c @@ -855,11 +855,16 @@ CheckRepetition(int p, int g) for (move_num = garray[g].game_state.lastIrreversable; move_num < garray[g].numHalfMoves - 1; move_num++) { + size_t len[3]; + pos = GetFENpos(g, move_num); + len[0] = strlen(pos1); + len[1] = strlen(pos2); + len[2] = strlen(pos); - if (strlen(pos1) == strlen(pos) && !strcmp(pos1, pos)) + if (len[0] == len[2] && !strcmp(pos1, pos)) flag1++; - if (strlen(pos2) == strlen(pos) && !strcmp(pos2, pos)) + if (len[1] == len[2] && !strcmp(pos2, pos)) flag2++; } -- cgit v1.2.3