From 0e89fa93c9dc6268d779b5ef47055ff910a59e71 Mon Sep 17 00:00:00 2001
From: Markus Uhlin <markus@nifty-networks.net>
Date: Wed, 3 Jan 2024 02:56:50 +0100
Subject: Reformatted who_winloss(), replaced sprintf() with snprintf() and
 deleted unnecessary casts

---
 FICS/comproc.c | 93 ++++++++++++++++++++++++++++------------------------------
 1 file changed, 45 insertions(+), 48 deletions(-)

diff --git a/FICS/comproc.c b/FICS/comproc.c
index 0ddbb63..f54892a 100644
--- a/FICS/comproc.c
+++ b/FICS/comproc.c
@@ -864,60 +864,57 @@ who_verbose(int p, int num, int plist[])
 	pprintf(p, " +---------------------------------------------------------------+\n");
 }
 
-PRIVATE void who_winloss(p, num, plist)
-int p;
-int num;
-int plist[];
+PRIVATE void
+who_winloss(int p, int num, int plist[])
 {
-  int i, p1;
-  char playerLine[255], tmp[255];	/* for highlight */
-  char p1WithAttrs[255];
+	char	p1WithAttrs[255];
+	char	playerLine[255];
+	char	tmp[255];
+	int	p1;
 
-  pprintf(p,
-	  "Name               Stand     win loss draw   Blitz    win loss draw    idle\n"
-    );
-  pprintf(p,
-	  "----------------   -----     -------------   -----    -------------    ----\n"
-    );
+	pprintf(p, "Name               Stand     win loss draw   Blitz    win loss draw    idle\n");
+	pprintf(p, "----------------   -----     -------------   -----    -------------    ----\n");
 
-  for (i = 0; i < num; i++) {
-    playerLine[0] = '\0';
-    p1 = plist[i];
+	for (int i = 0; i < num; i++) {
+		playerLine[0] = '\0';
+		p1 = plist[i];
 
-    /* Modified by hersco to include lists in 'who n.' */
-    strcpy (p1WithAttrs, parray[p1].name);
-    AddPlayerLists(p1, p1WithAttrs);
-    p1WithAttrs[17] = '\0';
+		/* Modified by hersco to include lists in 'who n.' */
+		strcpy(p1WithAttrs, parray[p1].name);
+		AddPlayerLists(p1, p1WithAttrs);
+		p1WithAttrs[17] = '\0';
 
-    if (p1 == p) {
-      psprintf_highlight(p, playerLine, "%-17s", p1WithAttrs);
-    } else {
-      sprintf(playerLine, "%-17s", p1WithAttrs);
-    }
-    sprintf(tmp, "  %4s     %4d %4d %4d   ",
-	    ratstrii(parray[p1].s_stats.rating, parray[p1].registered),
-	    (int) parray[p1].s_stats.win,
-	    (int) parray[p1].s_stats.los,
-	    (int) parray[p1].s_stats.dra);
-    strcat(playerLine, tmp);
-
-    sprintf(tmp, "%4s    %4d %4d %4d   ",
-	    ratstrii(parray[p1].b_stats.rating, parray[p1].registered),
-	    (int) parray[p1].b_stats.win,
-	    (int) parray[p1].b_stats.los,
-	    (int) parray[p1].b_stats.dra);
-    strcat(playerLine, tmp);
-
-    if (player_idle(p1) >= 60) {
-      sprintf(tmp, "%5s\n", hms(player_idle(p1), 0, 0, 0));
-    } else {
-      sprintf(tmp, "     \n");
-    }
-    strcat(playerLine, tmp);
+		if (p1 == p) {
+			psprintf_highlight(p, playerLine, "%-17s", p1WithAttrs);
+		} else {
+			sprintf(playerLine, "%-17s", p1WithAttrs);
+		}
 
-    pprintf(p, "%s", playerLine);
-  }
-  pprintf(p, "    %3d Players Displayed.\n", num);
+		snprintf(tmp, sizeof tmp, "  %4s     %4d %4d %4d   ",
+		    ratstrii(parray[p1].s_stats.rating, parray[p1].registered),
+		    parray[p1].s_stats.win,
+		    parray[p1].s_stats.los,
+		    parray[p1].s_stats.dra);
+		strcat(playerLine, tmp);
+
+		snprintf(tmp, sizeof tmp, "%4s    %4d %4d %4d   ",
+		    ratstrii(parray[p1].b_stats.rating, parray[p1].registered),
+		    parray[p1].b_stats.win,
+		    parray[p1].b_stats.los,
+		    parray[p1].b_stats.dra);
+		strcat(playerLine, tmp);
+
+		if (player_idle(p1) >= 60) {
+			sprintf(tmp, "%5s\n", hms(player_idle(p1), 0, 0, 0));
+		} else {
+			sprintf(tmp, "     \n");
+		}
+
+		strcat(playerLine, tmp);
+		pprintf(p, "%s", playerLine);
+	}
+
+	pprintf(p, "    %3d Players Displayed.\n", num);
 }
 
 PRIVATE int who_ok(int p, unsigned int sel_bits)
-- 
cgit v1.2.3